Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal links clearer #863

Open
Algon-33 opened this issue Dec 5, 2024 · 5 comments · May be fixed by #871
Open

Make internal links clearer #863

Algon-33 opened this issue Dec 5, 2024 · 5 comments · May be fixed by #871
Assignees

Comments

@Algon-33
Copy link
Collaborator

Algon-33 commented Dec 5, 2024

Based on some feedback from Murphant's friend Claire, it might be a good idea to differentiate links to stampy articles vs external links. One way to do this is to mimic Gwern and place a little stampy symbol after links to our articles. See the image below for an example of Gwern doing this.
image

@melissasamworth

@LeMurphant
Copy link
Collaborator

LeMurphant commented Dec 10, 2024

Huh, it looks like the external link functionality used to exist on the old site #222

I'd rather we recreate the old functionality (external box on external links) rather than tag internal links. @Algon-33 said that he would like to have something for internal links as well. I will recreate the external link box, and we can discuss internal links after.

@LeMurphant LeMurphant self-assigned this Dec 10, 2024
@LeMurphant
Copy link
Collaborator

It looks like removing the icon for external links was on purpose, see #346

@Aprillion I don't understand the context for removing this functionality. Is it something that depended on the "cards" functionality of the old UI? Does it make sense to revert this commit? Would it break aisafety.com?

@Aprillion
Copy link
Collaborator

Aprillion commented Dec 12, 2024

@LeMurphant at the time, internal links opened the question "in-place" - the site was a list of questions that could be expanded or collapsed and a link would add an expanded question to your list ... while external links opened on new tab and the icon was there to distinguish between the 2 behaviours

by removing the in-place feature and opening all links on new tab, we didn't need to distinguish between 2 behaviours, all links behaved the same after #346

feel free to copy&paste reusable parts of the deleted code into appropriate places in new codebase + test how it works, but please don't just revert the git commit (I would expect we now have different file structure so it wouldn't work.. on the other hand you can try and see and then if it won't work there is always git reset --hard origin/master)

@LeMurphant
Copy link
Collaborator

Thanks for the context @Aprillion. My plan was to use the icon you were using previously to indicate not only that this would open a new page (all links do this) but that this links to a website that is not aisafety.info. Do you think it would be confusing to have this icon used in this way? Would another icon be better to denote "this is not on our website"?

@Aprillion
Copy link
Collaborator

Should be fine to reuse the currently-unused icon for new purpose, no opinion if it's the best one to choose from - maybe @melissasamworth has an opinion.

@LeMurphant LeMurphant linked a pull request Jan 2, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants