Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give instructions on packaging to a single file for adding to path #13

Open
Minion3665 opened this issue May 24, 2022 · 5 comments
Open
Assignees
Labels
enhancement New feature or request packaging This is to do with packaging
Milestone

Comments

@Minion3665
Copy link
Collaborator

Perhaps in a future commit we could make a "package.sh" script/similar? That would alleviate the complexity while also allowing us to cd relative to the script directory

Originally posted by @Minion3665 in #12 (comment)

@Minion3665
Copy link
Collaborator Author

Minion3665 commented May 24, 2022

From @SpyHoodle in the same comment thread

Some repositories do typically have a install.sh instead of just a package.sh. I suggest we work & talk on this in the issue.

@Minion3665 Minion3665 added packaging This is to do with packaging enhancement New feature or request labels May 24, 2022
@Minion3665 Minion3665 added this to the packaging milestone May 24, 2022
@Minion3665
Copy link
Collaborator Author

Minion3665 commented May 24, 2022

I suggest we don't have an install.sh unless we also intend to take steps to add to PATH in the same script; perhaps something like build.sh would be standard while also appropriate?

@SpyHoodle
Copy link
Owner

I can't see anyone wanting to build the package without installing it. Even if there was this would be a small subset of people, and it makes more sense to explain the building process for anyone that wants to do this. Originally I thought that we should make it install to PATH, but it seems like this would have many differences on systems, especially if someone ran it without even looking at it, which can happen often.

I still think, especially when we have packages for many distributions, we could add a "installing from source" section.

@Minion3665
Copy link
Collaborator Author

Minion3665 commented May 25, 2022

I can't see anyone wanting to build the package without installing it.

I agree, however if our script doesn't install it I still don't think it's right to call it install.sh, even if that's the process that most users will be undertaking when they run the script. If build.sh is more accurate it should probably be called that

@SpyHoodle
Copy link
Owner

Definitely agree with you, sorry this wasn't clear.

@SpyHoodle SpyHoodle linked a pull request Jun 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request packaging This is to do with packaging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants