You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Annotating functions defined in the same package with @wrapMethod or @replaceMethod generates a warning that WIDE does not support this kind of action (same-content-annotation). This can confuse developers into thinking this is completely impossible when it's just the fault of incomplete WIDE implementation.
Describe the solution you'd like
It would be better if this sort of action was possible and did not generate any warnings. Repeated use of the same annotatated code can still be an error.
Possible implementation: there should be a new symbol path component type that would distinguish regular functions from the annotated ones that do not add anything new. Now we have (T)ypes, (D)ata and (C)allables. The new type could be (A)nnotations or (R)eplacers.
Describe alternatives you've considered
If it's impossible it should at least say the warning can b ignored.
The text was updated successfully, but these errors were encountered:
Methods made with `@wrapMethod` and `@replaceMethod` now have path suffixes that distinguish them from regular methods.
This distinciton allows for situations where annotations are made for types in the same package #49
Removed the `SameContentAnnotation` error and all associated with it.
Settled for an implementation where wrapping and replacing functions simply get suffixes after the name component in the symbol path.
For example Foo:T/Bar@wrapped:C is a symbol path for a Bar method of Foo made with @wrapMethod.
Is your feature request related to a problem? Please describe.
Annotating functions defined in the same package with
@wrapMethod
or@replaceMethod
generates a warning that WIDE does not support this kind of action (same-content-annotation
). This can confuse developers into thinking this is completely impossible when it's just the fault of incomplete WIDE implementation.Describe the solution you'd like
It would be better if this sort of action was possible and did not generate any warnings. Repeated use of the same annotatated code can still be an error.
Possible implementation: there should be a new symbol path component type that would distinguish regular functions from the annotated ones that do not add anything new. Now we have (T)ypes, (D)ata and (C)allables. The new type could be (A)nnotations or (R)eplacers.
Describe alternatives you've considered
If it's impossible it should at least say the warning can b ignored.
The text was updated successfully, but these errors were encountered: