-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Documentation VII #2229
Conversation
Thank you so much Zach!!! This is great :) No not all widgets have a
The available backends are correctly listed in the API references: https://spikeinterface.readthedocs.io/en/latest/api.html#spikeinterface.widgets.plot_all_amplitudes_distributions |
Of course :)
Cool, I'll update the backend part of the docs soon. I wanted to update this because I constantly go to that section of the docs to remember the exact name of the plotting function I want (for example the name change from multicomp to multicomparison etc). |
@zm711 since you're at it, could you remove the Legacy part of the widgets API (https://spikeinterface--2229.org.readthedocs.build/en/2229/api.html#legacy-widgets) and check if all plot_functions are listed there? Thanks!!! |
Yep. I can do that as well. It's a holiday coming up here so it might not happen this week, but I'll put it on my todo list. |
No rush! I can also try to add them if you're ok with me pushing here :) |
Of course. Always. |
Just one note if you do push changes, just watch out editing core because I didn't build this on top of my new import docs with core edited so I'm hoping to avoid merge conflicts... (I know you were just planning on looking at api.rst, but just as a warning). |
Done and also fixed some other sphinx warnings and missing refs :) |
@@ -70,15 +71,15 @@ To install it, run: | |||
|
|||
.. code-block:: bash | |||
|
|||
pip install sortingview figurl-jupyter | |||
pip install sortingview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
@@ -16,15 +16,15 @@ spikeinterface.widgets | |||
|
|||
The easiest way to visualize :code:`spikeinterface` objects is to use the :code:`widgets` module for plotting. | |||
You can find an extensive description in the module documentation :ref:`modulewidgets` | |||
and many examples in this tutorial :ref:`sphx_glr_modules_gallery_widgets`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context, this was generating a missing reference and I couldn't find a way to ref a dynamically generated sphinx-gallery module, but just individual files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of the sphinx gallery stuff is annoying like that, but based on my reading they don't really have plans to try to patch things like that. Such is life I suppose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more typos while we are at it.
So in this documentation improvement I did:
widgets_list.py
is connected to in the docs. My question for that is: I addedmatplotlib
backend, but do all widgets now all have at least theipy
backend as well