Refactoring of GroundTruthStudy #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace into gt_study
group in same file CorrelogramGTComparison and CorrelogramGTStudy
alejoe91
requested changes
Sep 22, 2023
There was a problem hiding this comment.
@samuelgarcia this looks awesome!
I have several comments and suggestions!
thanks alessio Co-authored-by: Alessio Buccino <[email protected]>
|
@alejoe91 ready for a last check |
alejoe91
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of GroundTruthStudy
This depend on #1968
The old code was looping over a sorter list x a recording list.
Now this is more flexible and we can loop over many levels and have asymletrics comparisons list.
Close #2009