From f925c44fd5f9e706ac9beb1046ee789cc6fc6e15 Mon Sep 17 00:00:00 2001 From: Zach McKenzie <92116279+zm711@users.noreply.github.com> Date: Thu, 30 May 2024 16:15:27 +0100 Subject: [PATCH] remove numba type signature (#2932) Co-authored-by: Heberto Mayorquin --- src/spikeinterface/core/sorting_tools.py | 2 +- src/spikeinterface/postprocessing/correlograms.py | 5 ++--- src/spikeinterface/postprocessing/isi.py | 1 - src/spikeinterface/qualitymetrics/misc_metrics.py | 3 +-- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/spikeinterface/core/sorting_tools.py b/src/spikeinterface/core/sorting_tools.py index cdbd89d0fc..2313e7d253 100644 --- a/src/spikeinterface/core/sorting_tools.py +++ b/src/spikeinterface/core/sorting_tools.py @@ -108,7 +108,7 @@ def get_numba_vector_to_list_of_spiketrain(): import numba - @numba.jit((numba.int64[::1], numba.int64[::1], numba.int64), nopython=True, nogil=True, cache=False) + @numba.jit(nopython=True, nogil=True, cache=False) def vector_to_list_of_spiketrain_numba(sample_indices, unit_indices, num_units): """ Fast implementation of vector_to_dict using numba loop. diff --git a/src/spikeinterface/postprocessing/correlograms.py b/src/spikeinterface/postprocessing/correlograms.py index f0bd151c68..bc7d2578fa 100644 --- a/src/spikeinterface/postprocessing/correlograms.py +++ b/src/spikeinterface/postprocessing/correlograms.py @@ -316,7 +316,7 @@ def compute_correlograms_numba(sorting, window_size, bin_size): if HAVE_NUMBA: - @numba.jit((numba.int64[::1], numba.int32, numba.int32), nopython=True, nogil=True, cache=False) + @numba.jit(nopython=True, nogil=True, cache=False) def _compute_autocorr_numba(spike_times, window_size, bin_size): num_half_bins = window_size // bin_size num_bins = 2 * num_half_bins @@ -341,7 +341,7 @@ def _compute_autocorr_numba(spike_times, window_size, bin_size): return auto_corr - @numba.jit((numba.int64[::1], numba.int64[::1], numba.int32, numba.int32), nopython=True, nogil=True, cache=False) + @numba.jit(nopython=True, nogil=True, cache=False) def _compute_crosscorr_numba(spike_times1, spike_times2, window_size, bin_size): num_half_bins = window_size // bin_size num_bins = 2 * num_half_bins @@ -367,7 +367,6 @@ def _compute_crosscorr_numba(spike_times1, spike_times2, window_size, bin_size): return cross_corr @numba.jit( - (numba.int64[:, :, ::1], numba.int64[::1], numba.int32[::1], numba.int32, numba.int32), nopython=True, nogil=True, cache=False, diff --git a/src/spikeinterface/postprocessing/isi.py b/src/spikeinterface/postprocessing/isi.py index 3742cbfa96..c738383636 100644 --- a/src/spikeinterface/postprocessing/isi.py +++ b/src/spikeinterface/postprocessing/isi.py @@ -159,7 +159,6 @@ def compute_isi_histograms_numba(sorting, window_ms: float = 50.0, bin_ms: float if HAVE_NUMBA: @numba.jit( - (numba.int64[:, ::1], numba.int64[::1], numba.int32[::1], numba.int64[::1]), nopython=True, nogil=True, cache=False, diff --git a/src/spikeinterface/qualitymetrics/misc_metrics.py b/src/spikeinterface/qualitymetrics/misc_metrics.py index 6b77e23c35..b68c1b8683 100644 --- a/src/spikeinterface/qualitymetrics/misc_metrics.py +++ b/src/spikeinterface/qualitymetrics/misc_metrics.py @@ -1363,7 +1363,7 @@ def _compute_violations(obs_viol, firing_rate, spike_count, ref_period_dur, cont if HAVE_NUMBA: - @numba.jit((numba.int64[::1], numba.int32), nopython=True, nogil=True, cache=False) + @numba.jit(nopython=True, nogil=True, cache=False) def _compute_nb_violations_numba(spike_train, t_r): n_v = 0 N = len(spike_train) @@ -1383,7 +1383,6 @@ def _compute_nb_violations_numba(spike_train, t_r): return n_v @numba.jit( - (numba.int64[::1], numba.int64[::1], numba.int32[::1], numba.int32, numba.int32), nopython=True, nogil=True, cache=False,