From 9bc18978fbb56917b0f4fe46df7c3bc531f850a4 Mon Sep 17 00:00:00 2001 From: JoeZiminski Date: Thu, 27 Jun 2024 10:40:50 +0100 Subject: [PATCH] Add packaging to CI dependency. On branch add_kilosort4_wrapper_tests --- .github/scripts/check_kilosort4_releases.py | 1 - .github/workflows/test_kilosort4.yml | 2 +- src/spikeinterface/sorters/external/kilosort4.py | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/scripts/check_kilosort4_releases.py b/.github/scripts/check_kilosort4_releases.py index 05d8c0c614..de11dc974b 100644 --- a/.github/scripts/check_kilosort4_releases.py +++ b/.github/scripts/check_kilosort4_releases.py @@ -16,7 +16,6 @@ def get_pypi_versions(package_name): data = response.json() versions = list(sorted(data["releases"].keys())) versions = [ver for ver in versions if parse(ver) >= parse("4.0.5")] - versions.pop(versions.index("4.0.4")) return versions diff --git a/.github/workflows/test_kilosort4.yml b/.github/workflows/test_kilosort4.yml index 03db2b6170..088dd1a6a4 100644 --- a/.github/workflows/test_kilosort4.yml +++ b/.github/workflows/test_kilosort4.yml @@ -25,7 +25,7 @@ jobs: - name: Install dependencies run: | - pip install requests + pip install requests packaging - name: Fetch package versions from PyPI run: | diff --git a/src/spikeinterface/sorters/external/kilosort4.py b/src/spikeinterface/sorters/external/kilosort4.py index dba28f7244..eb1df7c455 100644 --- a/src/spikeinterface/sorters/external/kilosort4.py +++ b/src/spikeinterface/sorters/external/kilosort4.py @@ -163,7 +163,7 @@ def _run_from_folder(cls, sorter_output_folder, params, verbose): logging.basicConfig(level=logging.INFO) - if cls.get_sorter_version() < version.parse("4.0.5"): + if version.parse(cls.get_sorter_version()) < version.parse("4.0.5"): raise RuntimeError( "Kilosort versions before 4.0.5 are not supported" "in SpikeInterface. "