From 9fecf89ab6e2a3669310e2bfad49b8b6955c6036 Mon Sep 17 00:00:00 2001 From: Alessio Buccino Date: Fri, 3 Nov 2023 12:00:20 +0100 Subject: [PATCH 1/2] (test) fix maxwell tests --- .github/workflows/full-test-with-codecov.yml | 2 ++ .github/workflows/full-test.yml | 2 ++ src/spikeinterface/extractors/tests/test_neoextractors.py | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/full-test-with-codecov.yml b/.github/workflows/full-test-with-codecov.yml index a5561c2ffc..08e1ee6e1a 100644 --- a/.github/workflows/full-test-with-codecov.yml +++ b/.github/workflows/full-test-with-codecov.yml @@ -52,6 +52,8 @@ jobs: - name: Shows installed packages by pip, git-annex and cached testing files uses: ./.github/actions/show-test-environment - name: run tests + env: + HDF5_PLUGIN_PATH: ${{ github.workspace }}/hdf5_plugin_path_maxwell run: | source ${{ github.workspace }}/test_env/bin/activate pytest -m "not sorters_external" --cov=./ --cov-report xml:./coverage.xml -vv -ra --durations=0 | tee report_full.txt; test ${PIPESTATUS[0]} -eq 0 || exit 1 diff --git a/.github/workflows/full-test.yml b/.github/workflows/full-test.yml index dad42e021b..2f5fa02a0f 100644 --- a/.github/workflows/full-test.yml +++ b/.github/workflows/full-test.yml @@ -132,6 +132,8 @@ jobs: - name: Test core run: ./.github/run_tests.sh core - name: Test extractors + env: + HDF5_PLUGIN_PATH: ${{ github.workspace }}/hdf5_plugin_path_maxwell if: ${{ steps.modules-changed.outputs.EXTRACTORS_CHANGED == 'true' || steps.modules-changed.outputs.CORE_CHANGED == 'true' }} run: ./.github/run_tests.sh "extractors and not streaming_extractors" - name: Test preprocessing diff --git a/src/spikeinterface/extractors/tests/test_neoextractors.py b/src/spikeinterface/extractors/tests/test_neoextractors.py index 64c6499767..f52d3d52bc 100644 --- a/src/spikeinterface/extractors/tests/test_neoextractors.py +++ b/src/spikeinterface/extractors/tests/test_neoextractors.py @@ -278,7 +278,7 @@ class CedRecordingTest(RecordingCommonTestSuite, unittest.TestCase): ] -@pytest.mark.skipif(ON_GITHUB, reason="Maxwell plugin not installed on GitHub") +# @pytest.mark.skipif(ON_GITHUB, reason="Maxwell plugin not installed on GitHub") class MaxwellRecordingTest(RecordingCommonTestSuite, unittest.TestCase): ExtractorClass = MaxwellRecordingExtractor downloads = ["maxwell"] From 6fd40a841c8b6b26d801ab5976ef51e1c4a19052 Mon Sep 17 00:00:00 2001 From: Alessio Buccino Date: Fri, 3 Nov 2023 12:10:39 +0100 Subject: [PATCH 2/2] Remove comment --- src/spikeinterface/extractors/tests/test_neoextractors.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/spikeinterface/extractors/tests/test_neoextractors.py b/src/spikeinterface/extractors/tests/test_neoextractors.py index f52d3d52bc..14f94eb20b 100644 --- a/src/spikeinterface/extractors/tests/test_neoextractors.py +++ b/src/spikeinterface/extractors/tests/test_neoextractors.py @@ -278,7 +278,6 @@ class CedRecordingTest(RecordingCommonTestSuite, unittest.TestCase): ] -# @pytest.mark.skipif(ON_GITHUB, reason="Maxwell plugin not installed on GitHub") class MaxwellRecordingTest(RecordingCommonTestSuite, unittest.TestCase): ExtractorClass = MaxwellRecordingExtractor downloads = ["maxwell"]