-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using lux.js in private project #59
Comments
Hi there! This is not legal advice but the short version is: in most cases you don't need to worry about the license. Any code that you generate from this source code can be redistributed without the license. The slightly longer version:
I hope that helps :) |
@josephwynn-sc, thank you for the quick answer, that helped a lot! While I have you, can you point me in the direction to where you make support for measuring LCP and CLS in Safari in the repo? I've tried to find ways to support this as Google's web-vitals package doesnt do that. |
@petermartings1978 unfortunately it's not possible to measure any of the web vitals metrics in Safari. Those metrics require support from the browser itself and cannot be polyfilled. It's not even possible to approximate the values 😢 The WebKit engineering manager was actually asking for opinions about this the other day on BlueSky: https://bsky.app/profile/nicolesullivan.bsky.social/post/3lbduwl3xqc26 |
@josephwynn-sc, Oh okay. I thought speedcurve collected web vitals from Safari too. So its not collecting other metrics than Googles web-vitals? Interesting thread! |
@petermartings1978 web-vitals collects 6 metrics, each with different levels of browser support:
The browser support is universal, so it doesn't matter which library you use to collect these metrics. lux.js collects these metrics plus dozens more. We have a metric glossary - any metric with "RUM next to it" is collected by lux.js. |
Hi SpeedCurve
This is not a bug report, but just a question.
As I understand the LICENSE I am allowed to use your repo in my own project, as long as I keep the copyright statement intact.
Is that a correct understanding? And if so, where should that copyright statement be stated? Is it in the minified lux.js file I generate?
The text was updated successfully, but these errors were encountered: