Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP Property Processor Refactor and Testing #96

Closed
wants to merge 16 commits into from
Closed

LDAP Property Processor Refactor and Testing #96

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
29ed5a4
Prepare domain object attributes for ADCS ESC6
definitelynotagoblin Jan 10, 2024
7b9a391
Correct property parsing, add produce false properties for uac
definitelynotagoblin Jan 11, 2024
e5f03e7
Correct email tests for ReadUser and ReadComputer Properties
definitelynotagoblin Jan 16, 2024
fc207bb
WIP LDAPPropertyProcessor refactor
definitelynotagoblin Jan 16, 2024
36f5748
Bring LDAPPropertyProcessor back into a builable state
definitelynotagoblin Jan 16, 2024
a36b351
And passing tests
definitelynotagoblin Jan 16, 2024
b5416de
Broke down ReadUser and ReadComputer Property methods
definitelynotagoblin Jan 16, 2024
baff724
Better manage SidHistory property addition
definitelynotagoblin Jan 16, 2024
e4f8f71
Reorganizing GetProperties
definitelynotagoblin Jan 17, 2024
7b28a4b
Correct FunctionalLevelToString placement to satisfy build
definitelynotagoblin Jan 17, 2024
2be6f38
Break ReadSidHistory into composite functions
definitelynotagoblin Jan 17, 2024
6b9a700
Begin adding tests for new functions
definitelynotagoblin Jan 18, 2024
8f226d0
Bolster LdapPropertyProcessor tests
definitelynotagoblin Jan 18, 2024
01189bb
Correct ReadSmsaPrincipals test
definitelynotagoblin Jan 18, 2024
0089492
Add simple property tests
definitelynotagoblin Jan 22, 2024
01ce4dd
Merge branch 'v3' into anemeth/ldap-property-map
definitelynotagoblin Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/CommonLib/Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,14 @@ public static Label GetLabel(this SearchResultEntry entry)
return objectType;
}

public static void AddRange<T, U>(this Dictionary<T, U> me, IEnumerable<KeyValuePair<T, U>> keyValuePairs)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should rename to AddMany?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caveat: not a c# expert

I tend to agree that AddRange is a little unintuitive about what this function is doing. Some additional ideas off the top of my head:

  • AddEntries
  • Assign
  • AddToDict

That said, whatever you end up calling it, it's probably a good idea to document the API so folks can rely on their intellisense to figure out what it does.

{
foreach (var kvp in keyValuePairs)
{
me.Add(kvp.Key, kvp.Value);
}
}

private const string GroupPolicyContainerClass = "groupPolicyContainer";
private const string OrganizationalUnitClass = "organizationalUnit";
private const string DomainClass = "domain";
Expand Down
Loading
Loading