BED-4965 - Owns/Owner Rework #176
Conversation
| } | ||
| } | ||
|
|
||
| public async Task<(ACE[], bool, bool)> ProcessACL(byte[] ntSecurityDescriptor, string objectDomain, |
There was a problem hiding this comment.
Can we move the optional parameter to a non-optional one? Currently, the overload is actually only used if you manually specify the bool, since the other ProcessACL function has the same number of arguments. Let's make it explicit what we're asking for
There was a problem hiding this comment.
Its actually not going to build on CI either
There was a problem hiding this comment.
Thanks for the review, Rohan!
Can we move the optional parameter to a non-optional one? Currently, the overload is actually only used if you manually specify the bool, since the other ProcessACL function has the same number of arguments. Let's make it explicit what we're asking for
I made checkForOwnerRights optional because objectName was already optional in the latest v4, and I couldn't add a required parameter after an optional one. Would you like me to make objectName required as well or split it into two methods, one for each signature?
Its actually not going to build on CI either
What do I need to do to address this?
There was a problem hiding this comment.
No, just move checkForOwnerRights before objectName, since this is a new function it shouldn't matter
Description
Updated SharpHound to collect two new properties for every domain object:
Motivation and Context
https://specterops.atlassian.net/browse/BED-4965
During ingest, BloodHound will use this information to determine whether any benign, non-abusable ACEs granted permissions to the OWNER RIGHTS SID (S-1-3-4), and whether or not any such ACEs were inherited. These properties allow ingest to determine whether any Owns and WriteOwner permissions granted are abusable or not.
How Has This Been Tested?
Please refer to https://specterops.atlassian.net/wiki/spaces/BE/pages/750157858/Owns+WriteOwner for detailed testing information.
Screenshots (if appropriate):
Types of changes
Checklist: