Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Organizational Units ACLs #118

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

q-roland
Copy link
Contributor

Description

This pull request adds the collection of two ACLs related to Organizational Units: GenericWrite and Manage Group Policy Links. The motivation behind the pull request is described in the following article: https://www.synacktiv.com/publications/ounedpy-exploiting-hidden-organizational-units-acl-attack-vectors-in-active-directory

Motivation and Context

This is a new feature adding two potentially exploitable OU ACLs to the collector. Note that a similar pull request was created for the python collector BloodHound.py. An additional pull request was created for the Specterops BloodHound GUI, in order to create two new edges associated with the GenericWrite and Manage Group Policy Links OU ACLs.

How Has This Been Tested?

Various domain extracts with the SharpHound binary built with the modified SharpHoundCommon DLL have been performed and result in the collection of the GenericWrite and Manage Group Policy Links permissions on OUs as expected.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

About this part, I do not think that documentation updates are necessary, nor the addition of tests, but feel free to correct me if I am wrong !

I am at your disposal for any further information

Copy link

github-actions bot commented Apr 19, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@q-roland
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@q-roland q-roland force-pushed the additionalOUACLs branch from 2427506 to 1f2d509 Compare May 8, 2024 15:59
@superlinkx
Copy link
Contributor

Holding off for one more cycle as we ingest some additional SharpHound improvements. Ready to go otherwise.

@irshadaj irshadaj added the blocked Blocked on other work or requirements label Jul 17, 2024
@JonasBK JonasBK merged commit d61b8f7 into SpecterOps:v3 Aug 26, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
@JonasBK
Copy link
Collaborator

JonasBK commented Aug 26, 2024

I forgot to update it to the v4 branch... Created a new PR here targeting v4: #156

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked Blocked on other work or requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants