refactor: explicit nullable parameters #4251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ Why should it be added? What are the benefits of this change?
This PR makes Laravel-Excel compatible with PHP 8.4 without throwing deprecation warnings while maintaining backwards compatibility. There is a similar PR (#4248), but that one is also incorporating some breaking changes.
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No.
3️⃣ Does it include tests, if possible?
Tests are already running for 8.4.
4️⃣ Any drawbacks? Possible breaking changes?
No.
5️⃣ Mark the following tasks as done:
6️⃣ Thanks for contributing! 🙌