Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: explicit nullable parameters #4251

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

joostdebruijn
Copy link
Contributor

1️⃣ Why should it be added? What are the benefits of this change?

This PR makes Laravel-Excel compatible with PHP 8.4 without throwing deprecation warnings while maintaining backwards compatibility. There is a similar PR (#4248), but that one is also incorporating some breaking changes.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.

No.

3️⃣ Does it include tests, if possible?

Tests are already running for 8.4.

4️⃣ Any drawbacks? Possible breaking changes?

No.

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.

6️⃣ Thanks for contributing! 🙌

@patrickbrouwers patrickbrouwers merged commit 6261631 into SpartnerNL:3.1 Nov 25, 2024
19 checks passed
@joostdebruijn joostdebruijn deleted the refactor/php84-compat branch November 25, 2024 19:00
@patrickbrouwers
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants