Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for limiting based on maximum concurrent connections #8

Open
S48-Mo opened this issue Jun 9, 2021 · 2 comments
Open

Add support for limiting based on maximum concurrent connections #8

S48-Mo opened this issue Jun 9, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@S48-Mo
Copy link
Contributor

S48-Mo commented Jun 9, 2021

As per BigCommerce's API rate-limit spec there can only be 10 concurrent requests to /v3/customers and 3 concurrent requests to all other endpoints. API calls are metered per-store, per-endpoint.
Add an enchancement to honour this limitation.

@S48-Mo S48-Mo added the enhancement New feature or request label Jun 9, 2021
@joshdifabio
Copy link
Contributor

We should investigate this further; we use a concurrency of >=50 in some places without issue.

@punkstar
Copy link
Contributor

I'd be interested in exploring if we could just monitor any unexpected 429 responses (where expected is defined based on known rate limiting headers) and keep increasing linearly until we get those responses or something more advanced like slow-start.

I'd also be really interested in reporting to the user when rate limiting has been detected to aid debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants