Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when trying to move non-existent source and --auto-rotation enabled #78

Open
dvzrv opened this issue Jun 4, 2017 · 1 comment

Comments

@dvzrv
Copy link
Contributor

dvzrv commented Jun 4, 2017

A call to Controller::orient_source_toward_reference with a non-existent id makes SSR crash.
This will happen, when calling Controller::set_source_position (also with non-existent id) and --auto-rotation being enabled (by default).

A prior call to ssr::Scene::get_source_orientation() in Controller::orient_source_toward_reference with the same (non-existent) id and a subsequent check for null_ptr could probably prevent this.

@dvzrv
Copy link
Contributor Author

dvzrv commented Jun 5, 2017

#79 fixes this, however, I'm not sure it's the best way. Maybe a first general check to whether the Source is available at all would be better, so subsequent calls to functions can be stopped at that point already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant