Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync XY (gridIndexHorizontal) between core and IDE #13

Open
elliottkember opened this issue Feb 20, 2021 · 0 comments
Open

Sync XY (gridIndexHorizontal) between core and IDE #13

elliottkember opened this issue Feb 20, 2021 · 0 comments

Comments

@elliottkember
Copy link
Contributor

// // Mirrored left-to-right

https://github.com/Soulmate-Lights/soulmate-core/blob/6b75bde357184c81de063674afab4824740cbac6/SoulmateMatrix.h#L132

Uh oh these ended up different! The new feature for SOULMATE_MIRROR / SOULMATE_REVERSE looks like it wasn't copied into the emulator code somehow. There may still be a transform on the canvas.

It's probably worth hoisting the XY() function so it exists in the IDE in both preview and simulator sketches, and then add an #ifdef into the core, so that we can force this to be consistent in the IDE between simulator and firmware builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant