From 29827323c2549a90a33145997ee7cbdac29f2c7b Mon Sep 17 00:00:00 2001 From: hendrik-buchwald-sonarsource Date: Wed, 13 Nov 2024 15:55:43 +0000 Subject: [PATCH 1/2] Create rule S7163 --- rules/S7163/metadata.json | 2 ++ rules/S7163/secrets/metadata.json | 56 +++++++++++++++++++++++++++++++ rules/S7163/secrets/rule.adoc | 50 +++++++++++++++++++++++++++ 3 files changed, 108 insertions(+) create mode 100644 rules/S7163/metadata.json create mode 100644 rules/S7163/secrets/metadata.json create mode 100644 rules/S7163/secrets/rule.adoc diff --git a/rules/S7163/metadata.json b/rules/S7163/metadata.json new file mode 100644 index 00000000000..2c63c085104 --- /dev/null +++ b/rules/S7163/metadata.json @@ -0,0 +1,2 @@ +{ +} diff --git a/rules/S7163/secrets/metadata.json b/rules/S7163/secrets/metadata.json new file mode 100644 index 00000000000..6cccb2e2e76 --- /dev/null +++ b/rules/S7163/secrets/metadata.json @@ -0,0 +1,56 @@ +{ + "title": "SECRET_TYPE should not be disclosed", + "type": "VULNERABILITY", + "code": { + "impacts": { + "SECURITY": "HIGH" + }, + "attribute": "TRUSTWORTHY" + }, + "status": "ready", + "remediation": { + "func": "Constant\/Issue", + "constantCost": "30min" + }, + "tags": [ + "cwe", + "cert" + ], + "defaultSeverity": "Blocker", + "ruleSpecification": "RSPEC-7163", + "sqKey": "S7163", + "scope": "All", + "securityStandards": { + "CWE": [ + 798, + 259 + ], + "OWASP": [ + "A3" + ], + "CERT": [ + "MSC03-J." + ], + "OWASP Top 10 2021": [ + "A7" + ], + "PCI DSS 3.2": [ + "6.5.10" + ], + "PCI DSS 4.0": [ + "6.2.4" + ], + "ASVS 4.0": [ + "2.10.4", + "3.5.2", + "6.4.1" + ], + "STIG ASD_V5R3": [ + "V-222642" + ] + }, + "defaultQualityProfiles": [ + "Sonar way" + ], + "quickfix": "unknown" +} diff --git a/rules/S7163/secrets/rule.adoc b/rules/S7163/secrets/rule.adoc new file mode 100644 index 00000000000..28f3a64def8 --- /dev/null +++ b/rules/S7163/secrets/rule.adoc @@ -0,0 +1,50 @@ + +include::../../../shared_content/secrets/description.adoc[] + +== Why is this an issue? + +include::../../../shared_content/secrets/rationale.adoc[] + +=== What is the potential impact? + +// Optional: Give a general description of the secret and what it's used for. + +Below are some real-world scenarios that illustrate some impacts of an attacker +exploiting the secret. + +// Set value that can be used to refer to the type of secret in, for example: +// "An attacker can use this {secret_type} to ..." +:secret_type: secret + +// Where possible, use predefined content for common impacts. This content can +// be found in the folder "shared_content/secrets/impact". +// When using predefined content, search for any required variables to be set and include them in this file. +// Not adding them will not trigger warnings. + +//include::../../../shared_content/secrets/impact/some_impact.adoc[] + +== How to fix it + +include::../../../shared_content/secrets/fix/revoke.adoc[] + +include::../../../shared_content/secrets/fix/vault.adoc[] + +=== Code examples + +:example_secret: example_secret_value +:example_name: java-property-name +:example_env: ENV_VAR_NAME + +include::../../../shared_content/secrets/examples.adoc[] + +//=== How does this work? + +//=== Pitfalls + +//=== Going the extra mile + +== Resources + +include::../../../shared_content/secrets/resources/standards.adoc[] + +//=== Benchmarks From ac34869d34733f9b91c97a76de9a636bbd249c9e Mon Sep 17 00:00:00 2001 From: Hendrik Buchwald Date: Thu, 14 Nov 2024 09:27:52 +0100 Subject: [PATCH 2/2] Update RSPEC? --- rules/S7163/secrets/metadata.json | 2 +- rules/S7163/secrets/rule.adoc | 29 +++++++---------------------- 2 files changed, 8 insertions(+), 23 deletions(-) diff --git a/rules/S7163/secrets/metadata.json b/rules/S7163/secrets/metadata.json index 6cccb2e2e76..6a4fec8d0cc 100644 --- a/rules/S7163/secrets/metadata.json +++ b/rules/S7163/secrets/metadata.json @@ -1,5 +1,5 @@ { - "title": "SECRET_TYPE should not be disclosed", + "title": "Mandrill API keys should not be disclosed", "type": "VULNERABILITY", "code": { "impacts": { diff --git a/rules/S7163/secrets/rule.adoc b/rules/S7163/secrets/rule.adoc index 28f3a64def8..8bc2b0d9dc4 100644 --- a/rules/S7163/secrets/rule.adoc +++ b/rules/S7163/secrets/rule.adoc @@ -7,21 +7,14 @@ include::../../../shared_content/secrets/rationale.adoc[] === What is the potential impact? -// Optional: Give a general description of the secret and what it's used for. - Below are some real-world scenarios that illustrate some impacts of an attacker exploiting the secret. -// Set value that can be used to refer to the type of secret in, for example: -// "An attacker can use this {secret_type} to ..." -:secret_type: secret +:secret_type: API key -// Where possible, use predefined content for common impacts. This content can -// be found in the folder "shared_content/secrets/impact". -// When using predefined content, search for any required variables to be set and include them in this file. -// Not adding them will not trigger warnings. +include::../../../shared_content/secrets/impact/phishing.adoc[] -//include::../../../shared_content/secrets/impact/some_impact.adoc[] +include::../../../shared_content/secrets/impact/financial_loss.adoc[] == How to fix it @@ -31,20 +24,12 @@ include::../../../shared_content/secrets/fix/vault.adoc[] === Code examples -:example_secret: example_secret_value -:example_name: java-property-name -:example_env: ENV_VAR_NAME +:example_secret: md-tYmfLurJdDlP4wDdOqEzZA +:example_name: mandrill-api-key +:example_env: MANDRILL_API_KEY include::../../../shared_content/secrets/examples.adoc[] -//=== How does this work? - -//=== Pitfalls - -//=== Going the extra mile - == Resources -include::../../../shared_content/secrets/resources/standards.adoc[] - -//=== Benchmarks +include::../../../shared_content/secrets/resources/standards.adoc[] \ No newline at end of file