Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #77

Open
2 of 4 tasks
microstudi opened this issue Apr 19, 2021 · 5 comments
Open
2 of 4 tasks

Bugfix #77

microstudi opened this issue Apr 19, 2021 · 5 comments

Comments

@microstudi
Copy link
Collaborator

microstudi commented Apr 19, 2021

@microstudi microstudi assigned microstudi and aitorlb and unassigned microstudi Apr 19, 2021
@aitorlb
Copy link
Contributor

aitorlb commented Apr 19, 2021

Meetings in the future should be ordered ASC. Meetings in the past should be ordered DESC.

Let's say today is 01-06-2020 and we have the following meetings:

past_meeting_1 { 01-05-2020 }     # 1 months away
past_meeting_2 { 01-03-2020 }     # 3 months away

upcoming_meeting_1 { 01-08-2020 } # 2 months away
upcoming_meeting_2 { 01-10-2020 } # 4 months away

When we filter meetings by both Upcoming and Past (example), what should be the correct order?

Should it be from closer to farther in time?

1. past_meeting_1 
2. upcoming_meeting_1
3. past_meeting_2
4. upcoming_meeting_2

@microstudi
Copy link
Collaborator Author

Very good question, In my view if both, past and future are listed, I'd continue to list future ASC and past DESC.

Ideally I'd like something like this:

  1. upcoming_meeting_1
  2. upcoming_meeting_2
    ---- Pasts meetings ----
  3. past_meeting_1
  4. past_meeting_2

But only if this does not complicate things too much.

I am also not sure of what Decidim Product will want so I'll make a mockup and a meta decidim proposal to try to figure it out.

In the meanwhile we only need that future proposals are ordered ASC, the rest can wait to be completed when we have an answer.

@microstudi
Copy link
Collaborator Author

This would be my ideal:
image

Adds the success class to the card--meeting when it is a future meeting, and adds a muted class when is passed.
Future events always ordered ASC, passed DESC.

@microstudi
Copy link
Collaborator Author

I've made this proposal, I'll update the result to finish this:
https://meta.decidim.org/processes/roadmap/f/122/proposals/16327

meanwhile we need to order ASC future events @aitorlb . Thanks

@aitorlb aitorlb removed their assignment Aug 26, 2021
@paarals
Copy link

paarals commented Oct 4, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants