Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate logging module instead of print function #104

Closed
tsingh2k15 opened this issue Dec 21, 2021 · 5 comments
Closed

Incorporate logging module instead of print function #104

tsingh2k15 opened this issue Dec 21, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@tsingh2k15
Copy link
Contributor

I wanted to share few of my thoughts and get your thoughts on it.

If any of these suggestions is relevant, I am open to collaborate and contribute on these. Thank you!

@tsingh2k15 tsingh2k15 changed the title Thoughts Thoughts/Questions Dec 21, 2021
@sfc-gh-jhansen
Copy link
Collaborator

Hey there @tsingh2k15, so sorry for the slow response here, things have been crazy! The second item doesn't seem as urgent as schemachange already has decent CLI support. But I am curious to hear more about your first item. And in particular I'm curious how it would then integrate with virtually any CI/CD tool like schemachange does now. By printing to the command line the CI/CD tools capture the output and make it easily viewable. How would this work with a logging library instead? (I haven't researched this so I'm curious).

@gudata
Copy link

gudata commented Sep 27, 2022

Not sure but I think the idea for the logging is that anyone can easly patch and create loggers / formatters to send the logs where they want (for example remote)

The logger by default could be configured to print to stdout.

Another benefit will that we can set the verbosity - debug, info etc.

@sfc-gh-tmathew sfc-gh-tmathew self-assigned this Sep 25, 2023
@sfc-gh-tmathew sfc-gh-tmathew added enhancement New feature or request help wanted Extra attention is needed labels Sep 25, 2023
@sfc-gh-tmathew
Copy link
Collaborator

Hello @tsingh2k15

As you can see that the current release of Schemachange has been rewritten in 3.5, please take a look and see how logger can be incorporated into the code.

Let us discuss how the logger library should be incorporated. I am open standardizing using the logger module but would like to understand the pros and cons if you have already thought about it.

Take a look at the current code base and please share your current thoughts.

cc: @gudata

@sfc-gh-tmathew
Copy link
Collaborator

@tsingh2k15 @gudata What logging patterns are you suggesting with logger module?

Would like to group this work along with #209 and #156 if you could give me a few pointers on how you see the logger module incorporated into the latest codebase.

@sfc-gh-tmathew
Copy link
Collaborator

As we work on the #275 and its related pieces, we will consider logging with backward compatibility. Please start using 3.7.0 and open new issues to start a new thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants