You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am trying to follow the documentation but noticed that there are a lot of inconsistencies with the name.
I think this is true in many places but I would like to focus on one in particular, https://docs.keydb.dev/docs/first-test/.
There are no such files: ./utils/KeyDB_init_script but there are ./utils/redis_init_script.
There are no such file: ./redis.conf but there are ./keydb.conf.
More importantly, the scripts themselves have mixed name. In the documentation, I am told to change KeyDBPort but there are no such variables, but there are REDISPORT.
I am probably going to find more.
I want to submit a PR but I don't know how big a change/what is the desired name to be.
I suspect this happened because the Redis documentation was simply find+replace'ed to KeyDB.
AFAIK, this project aims to have feature parity with Redis but with different internal implementation.
If that is the case, wouldn't it be better to simply have Redis docs + some appendix?
The text was updated successfully, but these errors were encountered:
hbina
changed the title
Lots of inconsistencies with regards to KeyDB <=> Redis
Lots of inconsistencies with regards to the name KeyDB <=> Redis
Oct 2, 2020
Actually this is really a twopart fix due to the inconsistent capitalization. The script in question should be ./utils/keydb_init_script and obviously the docs should have correct capitalization.
Some of these scripts get used by tests, and so the relevant TCL files need to be updated to call the correct script as well.
A bit more involved than a typo fix but if you are open to working on it I'd love the contribution!
I am trying to follow the documentation but noticed that there are a lot of inconsistencies with the name.
I think this is true in many places but I would like to focus on one in particular, https://docs.keydb.dev/docs/first-test/.
./utils/KeyDB_init_script
but there are./utils/redis_init_script
../redis.conf
but there are./keydb.conf
.KeyDBPort
but there are no such variables, but there areREDISPORT
.I am probably going to find more.
I want to submit a PR but I don't know how big a change/what is the desired name to be.
I suspect this happened because the Redis documentation was simply find+replace'ed to KeyDB.
AFAIK, this project aims to have feature parity with Redis but with different internal implementation.
If that is the case, wouldn't it be better to simply have Redis docs + some appendix?
The text was updated successfully, but these errors were encountered: