Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure youtube's new url path parameter (?si) is excluded #202

Open
Snailedlt opened this issue Oct 8, 2023 · 0 comments
Open

Make sure youtube's new url path parameter (?si) is excluded #202

Snailedlt opened this issue Oct 8, 2023 · 0 comments
Labels
app:api Anything related to the /apps/api backend api enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Milestone

Comments

@Snailedlt
Copy link
Owner

Youtube has a new url path parameter (?si) for tracking. This needs to be excluded when getting a thumbnail from the video id... so the regex needs to be updated. More info here: https://gist.github.com/rodrigoborgesdeoliveira/987683cfbfcc8d800192da1e73adc486?permalink_comment_id=4672606#gistcomment-4672606

Also, can we shorten the regex to this? (youtu.*be.*)\/(watch\?v=|embed\/|v|shorts|)(.*?((?=[&#?])|$)). Needs to be tested

@Snailedlt Snailedlt added enhancement New feature or request good first issue Good for newcomers app:api Anything related to the /apps/api backend api labels Oct 8, 2023
@Snailedlt Snailedlt changed the title Make sure youtube's new url path parameter (?si) excluded Make sure youtube's new url path parameter (?si) is excluded Oct 22, 2023
@Snailedlt Snailedlt added this to the v1 milestone Oct 30, 2023
@Snailedlt Snailedlt added help wanted Extra attention is needed hacktoberfest labels Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:api Anything related to the /apps/api backend api enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
Status: No status
Development

No branches or pull requests

1 participant