screenDiam validation

[illume]

See "instructions for writing a validation function". Below are notes from the spec, the original validation function (in the PHP language), and the SQL table structure.

screenDiam	Check for diameter range (d <0 and d> maxpossible raises an error). "SELECT TempID FROM ".$fileName." WHERE DBH<>0 AND (DBH>".$maxDBH." OR DBH<".$minDBH.") AND Errors<>'NONE' Minimum DBH for a stem is often 1.0, but this depends on whether site uses mm or cm.	Local	Checks to see if a tree’s diameter at breastheight (DBH) is within a predefined range.  Note that some sites record data in millimeters and others in centimeters, so minimum DBH is often 1.0 but not always.

Some was done on this already: see #107 (comment)

[siddheshraze]

Here is an updated procedure to run this and mark its errors in the CMVErrors table! Function's been reviewed with GPT so it should work as intended, but full testing is still pending:

create
    definer = azureroot@`%` procedure ValidateScreenMeasuredDiameterMinMax(IN minDBH decimal(10, 2), IN maxDBH decimal(10, 2))
BEGIN
    INSERT INTO forestgeo_bci.cmverrors (CoreMeasurementID, ValidationErrorID)
    SELECT
        CoreMeasurementID,
        2 AS ValidationErrorID
    FROM
        forestgeo_bci.coremeasurements
    WHERE
        MeasuredDBH < minDBH OR MeasuredDBH > maxDBH;
END;

[justinpac]

This is still pending because it needs to be integrated with the species limits table.

[justinpac]

There's some uncertainty about whether this is still needed. @siddheshraze to follow up with Stuart and Suzanne over email.

[siddheshraze]

This has been confirmed as needed -- species limits popup needs to be tested and verified as functioning correctly before this can be marked closed.