diff --git a/wayland-backend/CHANGELOG.md b/wayland-backend/CHANGELOG.md index c7c674668a8..6b893c75351 100644 --- a/wayland-backend/CHANGELOG.md +++ b/wayland-backend/CHANGELOG.md @@ -2,6 +2,9 @@ ## Unreleased +### Additions +- backend/server: Added a `destroy_object` method + ## 0.3.3 -- 2024-01-29 ### Additions diff --git a/wayland-backend/src/rs/server_impl/client.rs b/wayland-backend/src/rs/server_impl/client.rs index 44c216db6de..62179510f43 100644 --- a/wayland-backend/src/rs/server_impl/client.rs +++ b/wayland-backend/src/rs/server_impl/client.rs @@ -99,6 +99,17 @@ impl Client { InnerObjectId { id, serial, client_id: self.id.clone(), interface } } + pub(crate) fn destroy_object( + &mut self, + id: InnerObjectId, + pending_destructors: &mut Vec>, + ) -> Result<(), InvalidId> { + let object = self.get_object(id.clone())?; + pending_destructors.push((object.data.user_data.clone(), self.id.clone(), id.clone())); + self.send_delete_id(id.clone()); + Ok(()) + } + pub(crate) fn object_info(&self, id: InnerObjectId) -> Result { let object = self.get_object(id.clone())?; Ok(ObjectInfo { id: id.id, interface: object.interface, version: object.version }) @@ -199,7 +210,6 @@ impl Client { // Handle destruction if relevant if message_desc.is_destructor { - self.map.remove(object_id.id.id); if let Some(vec) = pending_destructors { vec.push((object.data.user_data.clone(), self.id.clone(), object_id.id.clone())); } @@ -376,7 +386,7 @@ impl Client { } } - fn get_object(&self, id: InnerObjectId) -> Result>, InvalidId> { + pub(crate) fn get_object(&self, id: InnerObjectId) -> Result>, InvalidId> { let object = self.map.find(id.id).ok_or(InvalidId)?; if object.data.serial != id.serial { return Err(InvalidId); diff --git a/wayland-backend/src/rs/server_impl/handle.rs b/wayland-backend/src/rs/server_impl/handle.rs index 7eb284acb91..107a2865a7b 100644 --- a/wayland-backend/src/rs/server_impl/handle.rs +++ b/wayland-backend/src/rs/server_impl/handle.rs @@ -162,6 +162,15 @@ impl InnerHandle { Ok(ObjectId { id: client.create_object(interface, version, data) }) } + pub fn destroy_object(&self, id: &ObjectId) -> Result<(), InvalidId> { + let mut state = self.state.lock().unwrap(); + let state = (&mut *state as &mut dyn ErasedState) + .downcast_mut::>() + .expect("Wrong type parameter passed to Handle::destroy_object()."); + let client = state.clients.get_client_mut(id.id.client_id.clone())?; + client.destroy_object(id.id.clone(), &mut state.pending_destructors) + } + pub fn null_id() -> ObjectId { ObjectId { id: InnerObjectId { diff --git a/wayland-backend/src/server_api.rs b/wayland-backend/src/server_api.rs index b3314870bd3..f1e14811199 100644 --- a/wayland-backend/src/server_api.rs +++ b/wayland-backend/src/server_api.rs @@ -357,6 +357,21 @@ impl Handle { self.handle.create_object(client_id.id, interface, version, data) } + /// Destroy an object + /// + /// For most protocols, this is handled automatically when a destructor + /// message is sent or received. + /// + /// This corresponds to `wl_resource_destroy` in the C API. + /// + /// # Panics + /// + /// This method will panic if the type parameter `D` is not same to the same type as the + /// one the backend was initialized with. + pub fn destroy_object(&self, id: &ObjectId) -> Result<(), InvalidId> { + self.handle.destroy_object::(id) + } + /// Send an event to the client /// /// Returns an error if the sender ID of the provided message is no longer valid. diff --git a/wayland-backend/src/sys/server_impl/mod.rs b/wayland-backend/src/sys/server_impl/mod.rs index f0d9c7c545f..e7df8aa51e3 100644 --- a/wayland-backend/src/sys/server_impl/mod.rs +++ b/wayland-backend/src/sys/server_impl/mod.rs @@ -565,6 +565,20 @@ impl InnerHandle { Ok(ObjectId { id: unsafe { init_resource(resource, interface, Some(data)).0 } }) } + pub fn destroy_object(&self, id: &ObjectId) -> Result<(), InvalidId> { + let mut state = self.state.lock().unwrap(); + // Keep this guard alive while the code is run to protect the C state + let state = (&mut *state as &mut dyn ErasedState) + .downcast_mut::>() + .expect("Wrong type parameter passed to Handle::destroy_object()."); + + PENDING_DESTRUCTORS.set(&(&mut state.pending_destructors as *mut _ as *mut _), || unsafe { + ffi_dispatch!(wayland_server_handle(), wl_resource_destroy, id.id.ptr); + }); + + Ok(()) + } + pub fn null_id() -> ObjectId { ObjectId { id: InnerObjectId {