node: Fix mask-or operator precedence by replacing + with |
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A request for using masks and shifts on the known `0-1-2` constants defining the minor type of a DRM node resulted in the expression to maintain the original `+` from first subtracting the current node type followed by adding the requested node type. As the subtract of the current node type was replaced by a mask, the resulting `old_id & ID_MASK + minor_base` expression is interpreted as `old_id & (ID_MASK + minor_base)` because of operator precedence, while it would have been correctly interpreted as `(old_id & ID_MASK) | minor_base` when the correct `|` OR operator is used.
MarijnS95
force-pushed
the
node-fix-mask-add
branch
from
7c47617 to
fe8f79c
Compare
Group all this logic together in functions inside `impl NodeType`.
MarijnS95
force-pushed
the
node-fix-mask-add
branch
from
fe8f79c to
4b08084
Compare
|
CI says:
Should we bump MSRV, lock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209, CC @jbeich
A request for using masks and shifts on the known
0-1-2constants defining the minor type of a DRM node resulted in the expression to maintain the original+from first subtracting the current node type followed by adding the requested node type. As the subtract of the current node type was replaced by a mask, the resultingold_id & ID_MASK + minor_baseexpression is interpreted asold_id & (ID_MASK + minor_base)because of operator precedence, while it would have been correctly interpreted as(old_id & ID_MASK) | minor_basewhen the correct|OR operator is used.