Fix crash when dropping removed token #155
Conversation
This fixes an issue where calloop would crash internally when the `PostAction::Drop` was invoked after the user manually cancelled the source in the callback.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 86.84% 86.75% -0.10%
==========================================
Files 14 14
Lines 1817 1819 +2
==========================================
Hits 1578 1578
- Misses 239 241 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Could you give a quick summary of what you changed and why? This diff is not very clear to read... |
Just changed the remove to try_remove. Just also tried to make the code somewhat readable at least. |
|
This probably needs a test given that it sounds like simple to repro? |
|
Alright, I took the time to figure out exactly what happens, and this seems like a good way to fix this, thanks. Could you please just add a changelog entry for this under the "unreleased" section? |
|
Ok so, it appears that a deeper issue with this PR as a special case was found & fixed in #156. |
|
closing in favor of #156 |
This fixes an issue where calloop would crash internally when the
PostAction::Dropwas invoked after the user manually cancelled the source in the callback.