Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is failing on coverage runs #183

Closed
elinorbgr opened this issue May 14, 2024 · 2 comments
Closed

CI is failing on coverage runs #183

elinorbgr opened this issue May 14, 2024 · 2 comments

Comments

@elinorbgr
Copy link
Member

I'm not sure what may be the cause, but it looks like our current CI fails in some jobs with the error message

fatal runtime error: IO Safety violation: owned file descriptor already closed

The interesting part is that it seems that the failing jobs are exactly the jobs measuring test coverage. Is there some weird interaction somewhere?

@notgull
Copy link
Member

notgull commented May 19, 2024

Fixed in #185, it looks like the cause was the nightly compiler rather than the coverage run

@notgull notgull closed this as completed May 19, 2024
@notgull
Copy link
Member

notgull commented May 19, 2024

Yeah, it looks like this line was added to stdlib in the latest nightly:

https://github.com/rust-lang/rust/blob/1d1283ed095ed605297b148e1284e1c53290ec91/library/std/src/os/fd/owned.rs#L181

This broke the "invalid FD" test we had earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants