Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review use of highlight colour on the bus_timetable #288

Open
jw35 opened this issue Feb 25, 2019 · 1 comment
Open

Review use of highlight colour on the bus_timetable #288

jw35 opened this issue Feb 25, 2019 · 1 comment
Labels
SmartPanels

Comments

@jw35
Copy link
Collaborator

jw35 commented Feb 25, 2019

The multiline display uses #FF0000 on #FFFFFF for delayed buses. This isn't a sufficient contract for web accessibility. Either using #AD0000, or using #FFFFFF on the #FFDDDD background used for similar highlighting elsewhere would be better.

However if using a background it should probably apply to the entire timetable entry, not just the delay line.
@jw35
Copy link
Collaborator Author

jw35 commented Apr 16, 2019

Colour fixed to #AD0000 in 37b7cd5 but we should consider reworking the display to use #000000 on a #FFDDDD background for the entirety of a problem entry as we do in other widgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SmartPanels
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jw35