Convert to Gradle Kotlin DSL #4175
Conversation
|
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4175/bfb6574f
|
|
Noticed intellij has an error with |
…t clean when building in gradle-compiler action
… slightly different file
…l-request action to build with a custom project version
…platform-launcher
| - name: Validate Gradle Wrapper | ||
| uses: gradle/actions/wrapper-validation@v3 | ||
|
|
||
| - name: Grant Wrapper Permission |
There was a problem hiding this comment.
I suggest we do this locally once (and push) instead of doing it every time in every task we want to invoke gradle
There was a problem hiding this comment.
I'm not entirely sure how the actions work so will need to figure out what you mean by that exactly
There was a problem hiding this comment.
build.gradle.kts
Outdated
| assemble { | ||
| dependsOn(shadowJar) | ||
|
|
||
| } |
There was a problem hiding this comment.
| assemble { | |
| dependsOn(shadowJar) | |
| } |
This bit is unneeded, shadowJar automatically assembles
There was a problem hiding this comment.
Yes but assemble does not automatically shadow. Without this calling gradle build will only build the unshaded jar. Nonetheless, we can remove this and just do gradle shadowJar
There was a problem hiding this comment.
Yep that's what I do with my gradle spigot plugins, no need to attach it to build
| include("plugin.yml") | ||
| include("config.yml") | ||
| include("item-models.yml") | ||
| include("wiki.json") | ||
| include("languages/translators.json") | ||
| include("tags/*.json") | ||
| include("biome-maps/*.json") | ||
| include("languages/**/*.yml") |
There was a problem hiding this comment.
Is this really needed? AFAIK all resources are automatically included
There was a problem hiding this comment.
Not sure, I'd have thought so too but I wonder why it was explicitly declared in the pom so I honored that explicit declaration. Can remove if there are no other reasons for it being explicitly declared.
There was a problem hiding this comment.
Can confirm all stuff is automatically included without that code
| include("tags/*.json") | ||
| include("biome-maps/*.json") | ||
| include("languages/**/*.yml") | ||
| filesMatching("plugin.yml") { |
There was a problem hiding this comment.
This can be replaced with the plugin-yml gradle plugin, tho idk how much others will want it
There was a problem hiding this comment.
Yes, haven't gotten to that part yet so I left it as we used to with maven resource filtering.
TheBusyBot
added
the
⚡ Merge Conflicts
Description
PoC of using Gradle as the buildscript
Proposed changes
Remove all maven buildscripts
Use the gradle wrapper and the gradle Kotlin DSL for buildscripts
Bumped minimum Java version to 17 due to dependency incompatibilities with Authlib being compiled against java 17.
Related Issues (if applicable)
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values