Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrowSampler::luaCreate potentially leaks lua objects #413

Open
jpswinski opened this issue Jun 11, 2024 · 1 comment
Open

ArrowSampler::luaCreate potentially leaks lua objects #413

jpswinski opened this issue Jun 11, 2024 · 1 comment
Assignees
@elidwa

Comments

@jpswinski
Copy link
Member

When an exception is thrown inside the luaCreate function of ArrowSampler, it looks like the _parms variable needs to be released via _parms->releaseLuaObject(). The same is true of the RasterObject robj variables that are added to the rasters vector. The list of robj RasterObjects also may need to be released as a part of the normal cleanup of the code during the ArrowSampler destructor for the private constructor case that takes the vector of rasters.
@elidwa elidwa mentioned this issue Jun 18, 2024
Merged
@elidwa
Copy link
Contributor

elidwa commented Jun 18, 2024

Fixed on branch luaCreateCleanup, PR pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elidwa elidwa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpswinski @elidwa