-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[choreo] Document Updater #926
Conversation
What are the steps for adding another schema version upgrade? We should document whatever that is in the interest of documenting maintenance tasks. |
Incrementing the constants for the schema version (its just an incrementing integer now for simplicity idk how you define semver for the schema stuff when any change is "breaking"). I admit there is more that goes into it than i would like but most actions that reduce complexity in schema management add complexity to some build step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Architecturally this seems reasonable. I'll have to think about ramifications of changing save file versioning to an int. I also don't know if we should require that Choreolib changes matching spec changes must go in the same PR.
I think we risk creating issues/having Choreolib fall behind similar to how C++ does if it's not updated in the same PR. |
I agree. I'm just wondering what effect that will have on PRs getting carried through to mergeability. |
If we can't get it done in the PR itself, I'd be concerned about it ever getting done, since maintainers can push directly to PRs. |
Items to address:
Item 3 is somewhat related to another issue about assembling a common set of test JSONs for all sorts of tests. |
…oreo into document-updater
…oreo into document-updater
Trackwidth work moved to #969 |
Needs unit tests but has been tested on my robot project
This pr also adds
trackwidth
to .traj output field to show off the upgrader, its just a dummy value of 1.0 for nowFixes #570.