Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] MacOS traffic light / window control buttons overlap with the sidebar #345

Open
5 of 6 tasks
arturfu-ext opened this issue Oct 31, 2024 · 3 comments
Open
5 of 6 tasks
Assignees
Labels
bug Something isn't working

Comments

@arturfu-ext
Copy link

arturfu-ext commented Oct 31, 2024

Describe the bug

When Window frame style is set to Hidden (default) in Obsidian's Appearance settings, the macOS's traffic light buttons overlap with the sidebar. The issue does not happen when the sidebar is collapsed. This issue arrived with one of the newer versions of the theme.

Expected behavior
The window control buttons should not overlap and be displayed in line with the sidebar buttons.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Appearance section of Obsidian's setting
  2. Switch Window frame style to Hidden (default)
  3. Expand the sidebar
  4. See error

Screenshots

image image image

Mode

What mode(s) does the bug occur? Select all that apply.

  • Source Mode
  • Live Preview
  • Reading Mode

OS

Where does the bug occur?

  • Desktop
  • Mobile

Versions

  • Obsidian Version: v1.7.4
  • ITS Theme Version: 1.3.24
  • Using ITS Snippet: Encoded Fonts, Encoded Icons
@arturfu-ext arturfu-ext added the bug Something isn't working label Oct 31, 2024
@SlRvb SlRvb added this to ITS Theme Nov 7, 2024
@SlRvb SlRvb moved this to Queue in ITS Theme Nov 7, 2024
@SlRvb SlRvb moved this from Queue to Done in ITS Theme Nov 7, 2024
@SlRvb
Copy link
Owner

SlRvb commented Nov 7, 2024

I don't have a mac so I can't 100% check that this is fix, but I think ITS v1.3.25 should fix this 🤔

@Sinled
Copy link

Sinled commented Nov 8, 2024

It seems i have the same problem in v1.3.25.
Have another vault with 1.3.16 version it doesn't have such problem

Screenshot 2024-11-08 at 16 41 18 Screenshot 2024-11-08 at 16 41 15

the difference in styles for .workspace-tab-header-container

v1.3.25 resets left padding

.workspace-split.workspace-split.mod-left-split.mod-left-split .workspace-tab-header-container,
.workspace-split.workspace-split .mod-top .workspace-tab-header-container {
    padding: 0;
}

in 1.3.16

.is-hidden-frameless:not(.is-fullscreen) .workspace-tabs.mod-top-left-space .workspace-tab-header-container {
    padding-left: calc(var(--size-4-2) + var(--frame-left-space));
}

@SlRvb SlRvb moved this from Done to In Progress in ITS Theme Nov 11, 2024
@SlRvb SlRvb moved this from In Progress to Done in ITS Theme Nov 30, 2024
@SlRvb
Copy link
Owner

SlRvb commented Nov 30, 2024

Sorry this took so long to get to! Should be fixed in ITS v1.3.30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants