Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpDate #7175

Open
wants to merge 18 commits into
base: dev/feature
Choose a base branch
from
Open

UpDate #7175

wants to merge 18 commits into from

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Nov 1, 2024

Description


Target Minecraft Versions: any
Requirements: none
Related Issues: #7161

@Efnilite Efnilite added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Nov 1, 2024
@Efnilite Efnilite requested a review from sovdeeth November 1, 2024 12:13
Copy link
Member

@Moderocky Moderocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may actually be better to just extend the Java date class, and change the existing method behaviour where necessary for compatibility.

@Efnilite Efnilite requested a review from Moderocky November 2, 2024 13:40
Copy link
Contributor

@Fusezion Fusezion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't mean much but here's this. Couldn't see anything from my scroll through

src/main/java/ch/njol/skript/util/Date.java Outdated Show resolved Hide resolved
src/main/java/ch/njol/skript/util/Date.java Outdated Show resolved Hide resolved
@Efnilite Efnilite requested a review from Moderocky November 12, 2024 18:04
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants