Rework number parser and angle support #7139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
added
the
enhancement
UnderscoreTud
requested changes
Oct 9, 2024
cheeezburga
approved these changes
Oct 12, 2024
sovdeeth
requested changes
Oct 12, 2024
sovdeeth
requested changes
Oct 12, 2024
sovdeeth
requested changes
Oct 12, 2024
# Conflicts: # src/main/java/ch/njol/skript/classes/data/JavaClasses.java # src/main/java/ch/njol/skript/effects/EffVectorRotateAroundAnother.java # src/main/java/ch/njol/skript/effects/EffVectorRotateXYZ.java
sovdeeth
approved these changes
Oct 15, 2024
sovdeeth
approved these changes
Nov 8, 2024
UnderscoreTud
approved these changes
Nov 20, 2024
Moderocky
approved these changes
Nov 30, 2024
Comment on lines
+32
to
+36
| Skript.registerExpression(ExprAngle.class, Number.class, ExpressionType.SIMPLE, | ||
| "%number% [in] deg[ree][s]", | ||
| "%number% [in] rad[ian][s]", | ||
| "%numbers% in deg[ree][s]", | ||
| "%numbers% in rad[ian][s]"); |
There was a problem hiding this comment.
Do you want to support gradians (grad[s]/gon) while you're here?
They're pretty obscure nowadays so I don't mind, but you do occasionally see them used in map stuff and cartography.
|
Good PR. I wondered about supporting the symbols too (e.g. |
Efnilite
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworks number parser. Adds support for angles. When using
x degrees, it is just syntactic sugar forx. When usingx radians, convertsxto degrees.Target Minecraft Versions: any
Requirements: none
Related Issues: none