From 63de21f0aa7db44f1f8849adb06f909ff984387f Mon Sep 17 00:00:00 2001 From: Dan Finlay Date: Wed, 7 Jun 2017 17:29:25 -0700 Subject: [PATCH] Correct personal_sign param ordering [It has been brought to my attention](https://github.com/MetaMask/metamask-plugin/issues/1557) that this (and in turn MetaMask's) personal_sign param ordering is incorrect. How did this happen? Was it [the lack of a standard RPC test suite?](https://github.com/ethereum/EIPs/issues/217) was it just my mistake? I'll claim both. The Wiki seems to be accurate in correcting us here, too: https://github.com/ethereum/go-ethereum/wiki/Management-APIs#personal_sign --- src/schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/schema.json b/src/schema.json index 44f6643..d93df0b 100644 --- a/src/schema.json +++ b/src/schema.json @@ -5,7 +5,7 @@ "net_version": [[], "S"], "net_peerCount": [[], "Q"], "net_listening": [[], "B"], - "personal_sign": [["D20", "D", "S"], "D", 2], + "personal_sign": [["D", "D20", "S"], "D", 2], "personal_ecRecover": [["D", "D"], "D20", 2], "eth_protocolVersion": [[], "S"], "eth_syncing": [[], "Boolean|EthSyncing"],