Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe deprecate use of project prototype #213

Open
Sjeiti opened this issue May 13, 2020 · 0 comments
Open

Maybe deprecate use of project prototype #213

Sjeiti opened this issue May 13, 2020 · 0 comments

Comments

@Sjeiti
Copy link
Owner

Sjeiti commented May 13, 2020

A legacy implementation is the project prototype. On the one hand this is a very neat way to add derived properties to an object (easy to interpolate), on the other hand it is somewhat of a hassle.

Right now the project prototype is only attached when needed: the reducer copies to an object literal. This is confusing since specific project properties are not always present.

We can either move all the project getters and setters to separate selector functions, or move the prototype down all the way and have the reducer clone the project with the prototype.

I think selectors are not the best solution in this case since it separates project properties to multiple files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant