Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dstore/Memory#setData does not update grid. #201

Closed
ghost opened this issue Jan 26, 2017 · 3 comments
Closed

dstore/Memory#setData does not update grid. #201

ghost opened this issue Jan 26, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 26, 2017

A declare([ Memory, Trackable]) object does not automatically update the grid.

When dstore/Memory#setData is called on a declare([ Memory, Trackable]) object, the grid is not updated. In order to update the grid a reference to the grid must be available (#refresh()) or the dojo/store/Memory#putSync method must be used.

In comparison, dojo/store/Memory#setData does update the associated dijit/form/Select object.

Should dstore/Memory#setData be made to update its associated grids?

@bklogic
Copy link

bklogic commented Aug 28, 2017

I see the same need.

@msssk
Copy link
Contributor

msssk commented Jan 16, 2020

This certainly seems to make sense on the surface. However, dgrid has always behaved this way, even the 0.3 releases that used Dojo object stores, so changing behavior at this point would be a breaking change. There may be other considerations as well.

@msssk
Copy link
Contributor

msssk commented Jan 16, 2020

Moved this to SitePen/dgrid#1448

@msssk msssk closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants