Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some horizontal row borders disappear when using Column Sets #1364

Open
msssk opened this issue Apr 24, 2017 · 1 comment
Open

Some horizontal row borders disappear when using Column Sets #1364

msssk opened this issue Apr 24, 2017 · 1 comment
Assignees

Comments

@msssk
Copy link
Contributor

msssk commented Apr 24, 2017

Looking at dgrid's test/complex_column.html page in Chrome 58 some horizontal row borders are missing. This is due to the element's height being set to 100%, which doesn't make sense since it doesn't have an explicitly sized parent.

Removing the height rule allows the element to vertically size correctly and the bottom border does not get cut off.

msssk added a commit to msssk/dgrid that referenced this issue May 8, 2017
@edhager edhager self-assigned this Jun 1, 2017
@edhager edhager removed their assignment Oct 31, 2017
@msssk
Copy link
Contributor Author

msssk commented Jan 8, 2020

Here are some images to clarify the problem (which still exists in Chrome as of version 79):

In the 3rd visible row, the cells in columns 1 and 2, with the values "note" and "false", have no border below them:

complex-column1

The same row when hovered makes the entire row dimensions clear:

complex-column1a

Removing the 100% height rule for the column set results in the borders being displayed along the bottom of the cells, but the cells do not expand vertically to fill the row, which I think is undesirable:

complex-column2

The following rule will reduce the height of the cell so that its border is not clipped:

.dgrid-column-set .dgrid-row-table {
  height: calc(100% - 1px);
}

complex-column3

This almost works, but the bottom border can end up misaligned with the bottom border on the adjacent cell.

Column Sets allow you to create some complicated structures that are rendered inconsistently across browsers. I'm not sure how to fix this, but we should at least record it as a known issue, with some information on possible solutions, perhaps in the Column Set documentation.

@msssk msssk self-assigned this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants