Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Forge Item Capabilities #158

Open
RainbowTabitha opened this issue Sep 30, 2024 · 6 comments
Open

Issue with Forge Item Capabilities #158

RainbowTabitha opened this issue Sep 30, 2024 · 6 comments

Comments

@RainbowTabitha
Copy link

RainbowTabitha commented Sep 30, 2024

When playing with any fabric mod in 1.20.1 and 1.21
Forge item capabilities are broken.

This issue is related to #121 and Sinytra/Connector#1441. except that i opened it in the wrong place.

Looking at issue Sinytra/Connector#1441 i was later informed this is a fabric api forgified bug and not a Connector issue.

I have later tested with multiple mods as such below and have seen item pipes do not connect to any tile entity if the pipe mod is from a forge mod. Using certain mods that extend vanilla items such as hoppers work fine but anything that is custom seems to break. Using LaserIO to force a connection pulls the cards out of the laserio node which makes me think its trying to pull the IInventory wrong.

I am going to look into this on my own time and try to submit a pull request.

image

image

Sorry if i was overly hostile, i was just kinda salty from the automated like responce of

As our LTS support target, 1.20.1 now only receives critical fixes related to Connector bugs. Please upgrade to the latest version for mod compatibility support.

when this bug seems to happen with many mods and would consider this critical because its inheritely an issue with how Forge Item Capabilites work and not a connector issue in general.

Tasks

No tasks being tracked yet.
@RainbowTabitha
Copy link
Author

Once again im sorry i was overly hostile, i just really would like to see this issue fixed, or atleast give me some pointers to submit a proper pull request.

@RainbowTabitha
Copy link
Author

I have identified that the issue is probably tied to the Fabric-transfer-API, going to look deeper into this myself

@RainbowTabitha
Copy link
Author

RainbowTabitha commented Sep 30, 2024

~~This commit seemed to of broke it https://modrinth.com/mod/forgified-fabric-api/version/0.89.0+1.9.24+1.20.1

4c6d1bc~~

I have since retracted this statement. Still trying to find the broken commit.

@RainbowTabitha
Copy link
Author

Yeah the pipes connect fine in 0.89.0+1.9.23
image

@RainbowTabitha
Copy link
Author

This is the broken commit b00938e.

Going to submit a PR to revert it. I do think that would be easiest solution.

@RainbowTabitha
Copy link
Author

I have since confirmed this is also broken in 1.21.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant