Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos with size parameters not centered #4426

Closed
andersweinstein opened this issue Nov 10, 2023 · 2 comments
Closed

Videos with size parameters not centered #4426

andersweinstein opened this issue Nov 10, 2023 · 2 comments
Labels
Bug Something isn't working Jira Create a Jira issue for this Migration Priority 3: Normal

Comments

@andersweinstein
Copy link
Contributor

Logic and Proofs migration results in videos that are not centered with respect to surrounding text. Experiment suggests this is because video size parameters were included and carried through in migration. In all cases the size parameters appear to specify the intrinsic resolution of the video with no scaling. For example, a video with resolution 500 x 400 includes size parameters of 500 and 400.

If the size parameters are removed in authoring the video displays centered though scaled up in size (to 814 x 648 in preview, 720x 576 in authoring, both of which preserve the 5:4 aspect ratio). With the size parameters it shows at the 500x400 size but is no longer centered; rather slightly indented on the left.

Can be seen on this authoring project page. This project has been superseded by a more recent migration so can be played with.
https://tokamak.oli.cmu.edu/authoring/project/logic_and_proofs_lt6tq/resource/yyb4k_overview_cicxl

@eliknebel eliknebel added Bug Something isn't working Priority 3: Normal Migration Jira Create a Jira issue for this labels Nov 14, 2023
Copy link

@eliknebel
Copy link
Contributor

The fix here is to remove the sizing of videos in the migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Jira Create a Jira issue for this Migration Priority 3: Normal
Projects
None yet
Development

No branches or pull requests

3 participants