-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Migration) Content element type 'figure' is not supported #4405
Comments
We should decide whether we actually need to support figures on torus or not, then determine if they should be migrated |
@drva will look into some accessibility considerations for the figure element |
The example is an untitled figure box element whose content consists of an image with caption. The caption in this case has some complex content (text and a link to the source). The migrated figure renders in authoring, showing the image only, but causes this error in preview/delivery. Experiment shows that adding a title to the figure element in authoring removes the problem. Even entering a title then changing it to empty fixes the problem. The issue therefore seems to be migration producing a figure box without a title element. However, there is also ANOTHER issue: the image's caption is not being rendered in either authoring or preview/delivery in this case. It does appear the original image/caption content is migrating into the caption property of the image and getting correctly wrapped in a paragraph. In general, it does not appear to be necessary to wrap this image in a figure box at all, since there is no title for it and a caption is already included with the image. So one workaround might be just to delete the figure wrapper. |
Caption not showing likely because images are styled as inline, so migrating to torus inline images which don't show captions. |
Describe the bug
Figures do not migrate.
To Reproduce
Steps to reproduce the behavior:
https://tokamak.oli.cmu.edu/sections/systematic_reviews_and_metaana/page/i43sj_wellformulated_review_question_nxxjd
Search for "Content element type 'figure' is not supported. Please contact support with issue #RFDKS8PEMGKVW9JQUHSRQU"
Expected behavior
Figures to be migrated and displayed.
Screenshots
If applicable, add screenshots to help explain your problem.
The text was updated successfully, but these errors were encountered: