Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Migration) Content element type 'figure' is not supported #4405

Closed
halturner opened this issue Nov 7, 2023 · 6 comments
Closed

(Migration) Content element type 'figure' is not supported #4405

halturner opened this issue Nov 7, 2023 · 6 comments
Labels
Enhancement New feature or request Jira Create a Jira issue for this Migration

Comments

@halturner
Copy link

Describe the bug
Figures do not migrate.

To Reproduce
Steps to reproduce the behavior:
https://tokamak.oli.cmu.edu/sections/systematic_reviews_and_metaana/page/i43sj_wellformulated_review_question_nxxjd
Search for "Content element type 'figure' is not supported. Please contact support with issue #RFDKS8PEMGKVW9JQUHSRQU"

Expected behavior
Figures to be migrated and displayed.

Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot 2023-11-07 at 1 56 29 PM
Screenshot 2023-11-07 at 1 56 40 PM

@eliknebel
Copy link
Contributor

We should decide whether we actually need to support figures on torus or not, then determine if they should be migrated

@eliknebel eliknebel added Enhancement New feature or request Priority 2: High Migration Jira Create a Jira issue for this labels Nov 21, 2023
Copy link

@eliknebel
Copy link
Contributor

@drva will look into some accessibility considerations for the figure element

@andersweinstein
Copy link
Contributor

andersweinstein commented Nov 27, 2023

The example is an untitled figure box element whose content consists of an image with caption. The caption in this case has some complex content (text and a link to the source). The migrated figure renders in authoring, showing the image only, but causes this error in preview/delivery. Experiment shows that adding a title to the figure element in authoring removes the problem. Even entering a title then changing it to empty fixes the problem. The issue therefore seems to be migration producing a figure box without a title element.

However, there is also ANOTHER issue: the image's caption is not being rendered in either authoring or preview/delivery in this case. It does appear the original image/caption content is migrating into the caption property of the image and getting correctly wrapped in a paragraph.

In general, it does not appear to be necessary to wrap this image in a figure box at all, since there is no title for it and a caption is already included with the image. So one workaround might be just to delete the figure wrapper.

@andersweinstein
Copy link
Contributor

Caption not showing likely because images are styled as inline, so migrating to torus inline images which don't show captions.

@eliknebel
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Jira Create a Jira issue for this Migration
Projects
None yet
Development

No branches or pull requests

3 participants