Skip to content

Latest commit

 

History

History
147 lines (99 loc) · 5.43 KB

CONTRIBUTING.md

File metadata and controls

147 lines (99 loc) · 5.43 KB
Raw

Contributing to the ML Kit Samples

We'd love for you to contribute to our source code and to make the ML Kit samples even better than it is today! Here are the guidelines we'd like you to follow:

Code of Conduct

As contributors and maintainers of the ML kit samples project, we pledge to respect everyone who contributes by posting issues, updating documentation, submitting pull requests, providing feedback in comments, and any other activities.

Communication through any of the support channels (GitHub, StackOverflow, Google+, Twitter, etc.) must be constructive and never resort to personal attacks, trolling, public or private harassment, insults, or other unprofessional conduct.

We promise to extend courtesy and respect to everyone involved in this project regardless of gender, gender identity, sexual orientation, disability, age, race, ethnicity, religion, or level of experience. We expect anyone contributing to the project to do the same.

If any member of the community violates this code of conduct, the maintainers of the MLKit samples project may take action, removing issues, comments, and PRs or blocking accounts as deemed appropriate.

If you are subject to or witness unacceptable behavior, or have any other concerns, please drop us a line at [email protected].

Got a Question or Problem?

If you have questions about how to use the MLKit samples, please direct these to StackOverflow and use the mlkit tag. We are also available on GitHub issues.

If you feel that we're missing an important bit of documentation, feel free to file an issue so we can help. Here's an example to get you started:

What are you trying to do or find out more about?

Where have you looked?

Where did you expect to find this information?

Found an Issue?

If you find a bug in the source code or a mistake in the documentation, you can help us by submitting an issue to our GitHub Repository. Even better you can submit a Pull Request with a fix.

See below for some guidelines.

Submission Guidelines

Submitting an Issue

Before you submit your issue search the archive, maybe your question was already answered.

If your issue appears to be a bug, and hasn't been reported, open a new issue. Please fill out all information in the issue template to maximize the chance that we can help you.

If you get help, help others. Good karma rulez!

Submitting a Pull Request

Before you submit your pull request consider the following guidelines:

  • Search GitHub for an open or closed Pull Request that relates to your submission. You don't want to duplicate effort.

  • Please sign our Contributor License Agreement (CLA) before sending pull requests. We cannot accept code without this.

  • Make your changes in a new git branch:

    git checkout -b my-fix-branch master

  • Create your patch, including appropriate test cases.

  • Follow our Coding Rules.

  • Avoid checking in files that shouldn't be tracked (e.g *.class, .idea, .tmp). We recommend using a global gitignore for this.

  • Commit your changes using a descriptive commit message.

    git commit -a

    Note: the optional commit -a command line option will automatically "add" and "rm" edited files.

  • Build your changes locally to ensure all the tests pass:

    ./gradlew build

  • Push your branch to GitHub:

    git push origin my-fix-branch

  • In GitHub, send a pull request to mlkit:master.

  • If we suggest changes then:

    • Make the required updates.

    • Rebase your branch and force push to your GitHub repository (this will update your Pull Request):

      git rebase master -i
git push origin my-fix-branch -f

That's it! Thank you for your contribution!

After your pull request is merged

After your pull request is merged, you can safely delete your branch and pull the changes from the main (upstream) repository:

  • Delete the remote branch on GitHub either through the GitHub Android UI or your local shell as follows:

    git push origin --delete my-fix-branch

  • Check out the master branch:

    git checkout master -f

  • Delete the local branch:

    git branch -D my-fix-branch

  • Update your master with the latest upstream version:

    git pull --ff upstream master

Coding Rules

Try to follow the same code style you see in the repository.

Signing the CLA

Please sign our Contributor License Agreement (CLA) before sending pull requests. For any code changes to be accepted, the CLA must be signed. It's a quick process, we promise!

This guide was inspired by the AngularJS contribution guidelines.