-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PGN127507 not available. #219
Comments
No attachment? |
Sorry attached this time. |
Most if not all pgns have a corresponding test, that verifies that the SK output is generated correctly from test input data. Could you provide one? Take a look at for example https://github.com/SignalK/n2k-signalk/blob/master/test/127751_dv_voltage_current.js I haven't been following the canboat(js) related part of this - does this require an updated version of pgns.json? |
Please find attached what I hope is a correct test input data. The below is also candump data from my environment can0 19F21381 [8] A0 06 71 00 08 FC FF FF When piped through candumpanalyzerjs cat PGN127507-single.txt | /usr/local/lib/node_modules/signalk-server/node_modules/@canboat/canboatjs/bin/candumpanalyzerjs I also attach a longer extract from a candump with messages in form two different sources. One of which is a Victron Cerbo GX sending details about a MultiPlus. Regarding canboat(js)..... It already has a definition of 127507, however it was defined as a single packet rather than fast, so the first 2 bytes are being interpreted incorrectly. When the definition in pgns.xml and therefore pgns.json and pgn.h is made to move 127507 from single to fast and size from 8 to 6, canboatjs has problems parsing the frame. I have raised an issues (canboat/canboatjs#161) about this. Not having access to any other fast messages which are 6 bytes or less in size, I have not been able to identify how wide spread this issue is. I have managed to get my system working by defining the length in pgns.json of 127507 to be 9 bytes, and a fast packet.
The output above are using this definition Hope that all makes sense. cat PGN127507-single.txt | /usr/local/lib/node_modules/signalk-server/node_modules/@canboat/canboatjs/bin/candumpanalyzerjs |
Any progress on this? |
Now there is, see the linked PR. Would have happened probably sooner with a pull request instead of attachments. Everything that creates friction just lessens the chance of stuff moving forward. But here we are. |
It would seem that PGN127507 is not yet understood by Signal, but is by canboatjs.
canboatjs view
candump can1 | /usr/local/lib/node_modules/signalk-server/node_modules/@canboat/canboatjs/bin/candumpanalyzerjs | grep :129 | grep 127507
{"canId":435295105,"prio":6,"src":129,"dst":255,"pgn":127507,"timestamp":"2021-07-13T12:34:26.019Z","fields":{"Instance":64,"Battery Instance":6,"Operating State":"Off","Charge Mode":"Echo mode","Equalization Pending":"Off","Reserved1":"0","Equalization Time Remaining":64520},"description":"Charger Status"}
{"canId":435295105,"prio":6,"src":129,"dst":255,"pgn":127507,"timestamp":"2021-07-13T12:34:26.022Z","fields":{"Instance":96,"Battery Instance":6,"Operating State":"Off","Charge Mode":7,"Equalization Pending":"Off","Reserved1":"0","Equalization Time Remaining":64520},"description":"Charger Status"}
{"canId":435295105,"prio":6,"src":129,"dst":255,"pgn":127507,"timestamp":"2021-07-13T12:34:26.023Z","fields":{"Instance":128,"Battery Instance":6,"Operating State":2,"Charge Mode":7,"Equalization Pending":"On","Reserved1":"0","Equalization Time Remaining":64520},"description":"Charger Status"}
{"canId":435295105,"prio":6,"src":129,"dst":255,"pgn":127507,"timestamp":"2021-07-13T12:34:26.083Z","fields":{"Instance":160,"Battery Instance":6,"Operating State":"Off","Charge Mode":"Echo mode","Equalization Pending":"Off","Reserved1":"0","Equalization Time Remaining":64520},"description":"Charger Status"}
{"canId":435295105,"prio":6,"src":129,"dst":255,"pgn":127507,"timestamp":"2021-07-13T12:34:26.086Z","fields":{"Instance":192,"Battery Instance":6,"Operating State":"Off","Charge Mode":7,"Equalization Pending":"Off","Reserved1":"0","Equalization Time Remaining":64520},"description":"Charger Status"}
{"canId":435295105,"prio":6,"src":129,"dst":255,"pgn":127507,"timestamp":"2021-07-13T12:34:26.086Z","fields":{"Instance":224,"Battery Instance":6,"Operating State":2,"Charge Mode":7,"Equalization Pending":"On","Reserved1":"0","Equalization Time Remaining":64775},"description":"Charger Status"}
{"canId":435295105,"prio":6,"src":129,"dst":255,"pgn":127507,"timestamp":"2021-07-13T12:34:26.787Z","fields":{"Instance":0,"Battery Instance":6,"Operating State":"Off","Charge Mode":"Echo mode","Equalization Pending":"Off","Reserved1":"0","Equalization Time Remaining":64520},"description":"Charger Status"}
{"canId":435295105,"prio":6,"src":129,"dst":255,"pgn":127507,"timestamp":"2021-07-13T12:34:26.797Z","fields":{"Instance":32,"Battery Instance":6,"Operating State":"Off","Charge Mode":7,"Equalization Pending":"Off","Reserved1":"0","Equalization Time Remaining":64520},"description":"Charger Status"}
{"canId":435295105,"prio":6,"src":129,"dst":255,"pgn":127507,"timestamp":"2021-07-13T12:34:26.797Z","fields":{"Instance":64,"Battery Instance":6,"Operating State":2,"Charge Mode":7,"Equalization Pending":"On","Reserved1":"0","Equalization Time Remaining":64520},"description":"Charger Status"}
{"canId":435295105,"prio":6,"src":129,"dst":255,"pgn":127507,"timestamp":"2021-07-13T12:34:28.287Z","fields":{"Instance":96,"Battery Instance":6,"Operating State":"Off","Charge Mode":"Echo mode","Equalization Pending":"Off","Reserved1":"0","Equalization Time Remaining":64520},"description":"Charger Status"}
If you need raw candump data, please let me know.
The text was updated successfully, but these errors were encountered: