Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests+lint on push #36

Open
DomVinyard opened this issue Feb 28, 2023 · 1 comment
Open

Run tests+lint on push #36

DomVinyard opened this issue Feb 28, 2023 · 1 comment

Comments

@DomVinyard
Copy link
Collaborator

DomVinyard commented Feb 28, 2023

Task:

We know that every time we push to a branch or create a PR, a bunch of checks run within Netlify to tell us if there are any issues that would prevent our app from deploying. As part of GitHub Actions it is also possible to run our own manual checks:

Image

We need to create a new Github action that will automatically run the web tests (npm run test) and web linter (npm run lint) when a push is made to any branch. This action should be configured to work with the project repository and run on each push event.

Resources

Refresher Video
Github Docs

(For the linter, it may be preferable to use the Official Github Lint Action rather than use npm run lint. You may want to do some research to find out what the distinction is.)

Acceptance Criteria:

  • The Github action should run the tests and linter when a push is made to any branch.
  • The Github action should be configured with the project repository.
  • The Github action should run on each push event.
  • The tests should only run if the linter succeeds. If the linter fails then do not run the tests after.
@DomVinyard
Copy link
Collaborator Author

DomVinyard commented Feb 28, 2023

edit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant