Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken on node <= 8.9 #207

Open
Niels-Be opened this issue Jul 23, 2019 · 0 comments
Open

Build broken on node <= 8.9 #207

Niels-Be opened this issue Jul 23, 2019 · 0 comments

Comments

@Niels-Be
Copy link
Contributor

Last Changes for Node 12 broke builds for node versions that do not support Isolates in String::Utf8Value (node <= 8.9).

../src/dbus.cc: In function 'Nan::NAN_METHOD_RETURN_TYPE node_dbus::CallMethod(Nan::NAN_METHOD_ARGS_TYPE)':
../src/dbus.cc:219:61: error: no matching function for call to 'v8::String::Utf8Value::Utf8Value(v8::Isolate*, v8::Local<v8::String>)'
                   Nan::GetCurrentContext()).ToLocalChecked()));
                                                             ^
../src/dbus.cc:219:61: note: candidate is:
In file included from /home/rpxc-user/.node-gyp/8.9.4/include/node/node.h:63:0,
                 from ../../nan/nan.h:54,
                 from ../src/dbus.cc:2:
/home/rpxc-user/.node-gyp/8.9.4/include/node/v8.h:2764:14: note: v8::String::Utf8Value::Utf8Value(v8::Local<v8::Value>)
     explicit Utf8Value(Local<v8::Value> obj);
              ^
/home/rpxc-user/.node-gyp/8.9.4/include/node/v8.h:2764:14: note:   candidate expects 1 argument, 2 provided

node-dbus/src/dbus.cc

Lines 216 to 219 in 636180b

sig = strdup(*String::Utf8Value(
v8::Isolate::GetCurrent(),
mb_sig.ToLocalChecked()->ToString(
Nan::GetCurrentContext()).ToLocalChecked()));

A possible solution would be to use Nan::Utf8String.
Or at least write a note in the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant