-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script Tags are not being registered #1891
Comments
Hi @jagthedrummer thank you for opening this we can take a look. |
Hey there @jagthedrummer! The script tag manager was removed in version 22. In the upgrading guide you can find our recommendation. I do see that we still have the |
@lizkenyon, I see. FWIW, as a developer working in the Shopify ecosystem I feel it's pretty unfriendly (bordering on hostile) to purposefully remove working code over a full calendar year before the functionality supported by that code is slated to be dropped. |
I think that is very valid feedback. I will share with the team. |
@lizkenyon Any word on this? It would be great to have the ScriptManager added back since that feature isn't actually deprecated yet. |
Issue summary
Before opening this issue, I have:
shopify_app
version: 22.3.2log_level: :debug
in my configuration, if applicableWhen a shop installs the app the
scripttags
specified in the initializer aren't registered.Expected behavior
The
scripttags
listed in the initializer should be registered.Actual behavior
They are not registered.
Steps to reproduce the problem
scripttags
in a new shop.It looks like maybe something on the Shopify side broke this starting sometime in mid June.
I realize that script tags are deprecated, but all of the info I can find says that they should continue to work until August of 2025.
The text was updated successfully, but these errors were encountered: