-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Information on the Cookies this App is using #1825
Comments
AFAIK, since cookies have become so unreliable inside iframes, That being said, Rails still uses cookies to store things like flash. I've simply deleted the Going forward, it looks like Chrome will allow iframe cookies to work as long as the Anyway, I don't think The latest version of Rack (3.0.x) (and therefore Rails) don't support easily adding this attribute yet, but it looks like Rack 3.1 will have this feature. That thread also mentions a temporary workaround. |
Thanks for the update! I am not terribly worried about any impact here, but it was something my console flashed at me, and that got me wondering about impact. |
Hey folks, thanks for raising this! As @flavio-b pointed out, right now we don't rely on cookies at all for authentication any more, since browsers have been making it harder to use cookies within iframes for a while now. Right now we're not planning on going back to cookies for authentication, and we're working on some improvements for embedded apps which will rely solely on JWTs, which is a faster / easier solution when inside the iframe. That being said, we should probably still use the |
So there are two obvious choices:
In either case, minor stuff going on you say, and nothing impactful to this project, more or less just house cleaning cleanup. |
Overview
With concern for this aspect of Shopify Apps:
We now see Shopify issue this console warning:
Is this new feature of partioned attribute something we should be worried about now or is it a simple change coming?
The text was updated successfully, but these errors were encountered: