refactor: update the code as the laravel best practices #524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code as per Laravel best practices
After building couple of applications using this template I came across couple of issues and I have tried to address those in the PR to the best of my knowledge.
Using
env
directly in the service provider is not recommended. Allenv
values should be resolved viaconfig
.Decoupled shopify related business logic from
AppServiceProvider
, extract the logic into its own service providerShopifyServiceProvider
Implementing business logic directly into the
web.php
is not recommended. I have also organized theweb.php
file by moving the business logic to its own namespace and relevant controllers.