Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useProfiledNavigation fails with es6 enabled #75

Open
4 of 9 tasks
ElviraBurchik opened this issue Jun 3, 2022 · 1 comment
Open
4 of 9 tasks

useProfiledNavigation fails with es6 enabled #75

ElviraBurchik opened this issue Jun 3, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ElviraBurchik
Copy link
Contributor

Current behavior

In an app using es6 and older version of tslib such as 1.9.3 useProfiledNavigation fails with undefined is not a function error:

Expected behavior

useProfiledNavigation doesn't fail.

Platform:

  • iOS
  • Android

Packages

Which packages are affected by the issue?

  • @shopify/react-native-performance
  • @shopify/react-native-performance-lists-profiler
  • @shopify/flipper-plugin-react-native-performance
  • @shopify/react-native-performance-navigation
  • @shopify/react-native-performance-navigation-bottom-tabs
  • @shopify/react-native-performance-navigation-drawer

Environment

  • I've removed the packages that I don't use
package version
@shopify/react-native-performance 3.0.0
@shopify/react-native-performance-navigation 4.0.0
react-native 0.67.4
@ElviraBurchik ElviraBurchik added the bug Something isn't working label Jun 3, 2022
@ElviraBurchik
Copy link
Contributor Author

If anybody hits this issue, using the latest version of tslib as a dependency fixes the problem.

@ElviraBurchik ElviraBurchik added the good first issue Good for newcomers label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant