Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiled Navigation throws tslint errors with react-navigation/native-stack 6.9.12 #134

Open
2 of 9 tasks
nandinicbit1981 opened this issue Mar 13, 2023 · 0 comments
Open
2 of 9 tasks
Labels
bug Something isn't working

Comments

@nandinicbit1981
Copy link

Current behavior

Inbox team noticed tslint errors on .navigate function ( example here) when react-native/native-stack was upgraded to 6.9.12
Example:
Screenshot 2023-03-13 at 10 41 42 AM

Expected behavior

There should be no tslint errors when react-navigation packages are upgraded

To Reproduce

Please checkout this branch on inbox-client repo and dev up && dev fc. You should be able to see a bunch of tslint errors. This error also effects this upgrade

Platform:

  • iOS
  • Android

Packages

Which packages are affected by the issue?

  • @shopify/react-native-performance
  • @shopify/react-native-performance-lists-profiler
  • flipper-plugin-shopify-react-native-performance
  • @shopify/react-native-performance-navigation
  • @shopify/react-native-performance-navigation-bottom-tabs
  • @shopify/react-native-performance-navigation-drawer

Environment

  • I've removed the packages that I don't use
package version
@shopify/react-native-performance x.y.z
@shopify/react-native-performance-lists-profiler x.y.z
flipper-plugin-shopify-react-native-performance x.y.z
@shopify/react-native-performance-navigation x.y.z
@shopify/react-native-performance-navigation-bottom-tabs x.y.z
@shopify/react-native-performance-navigation-drawer x.y.z
@react-navigation/native x.y.z
@react-navigation/bottom-tabs x.y.z
@react-navigation/drawer x.y.z
@react-navigation/stack x.y.z
react-native x.y.z
@nandinicbit1981 nandinicbit1981 added the bug Something isn't working label Mar 13, 2023
@nandinicbit1981 nandinicbit1981 changed the title Profiled Navigation throws tslint errors with react-navigation/native 6.1.6 Profiled Navigation throws tslint errors with react-navigation/native-stack 6.9.12 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant