-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to define eJSON Secret labels? #682
Comments
Thank you @dturn for your answer. Thank you for providing a link to the right peace of code 👍. I would use those labels to filter the output of the commands to list the content of a given namespace for a given selector, for example everything about MongoDB and it would list the secrets, services, and so on. It doesn't look to hard to implement, but I'm too busy right now to implement it by myself. No promises, but I will try to do it. |
In case you missed it in the code snippet, any selectors used in the deploy commands are turned labels on the secrets generated. |
You are very right, I missed it and thank you! |
My use case is to set standard Kubernetes labels that tie a deployed resource to a service catalog. Namely, the well known labels I patched this in locally to assess "upstream mergability", and it's not a lot of SLOC for the approach "extra CLI param looped through to If you'd be generally willing to support this use case, please let me know and I can go through my org's CLA signing process and clean up the patch. |
This change adds the ability to set additional labels or provide default values for deployment commands. This also works for ejson secrets. `ejson-keys` as shared secret will not be labled. The functionality was not made available on `krane render` due to potentially confusing behaviour around labels on secrets when using `krane render … | krane deploy -f secrets.ejson -f -` . Allowing labels specified in the templates take precedence is an intentional choice. It is the more flexible approach and allows customization for edge cases like migrations and "nested" deployments. see Shopify#682
I'm using the ejson gem in order to encrypt the secrets, and I'd like to set labels.
I tried the following, but it didn't work:
Can you please guide me on how to add labels to secrets using ejson?
The text was updated successfully, but these errors were encountered: